Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loding sub dirs #81

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: loding sub dirs #81

merged 1 commit into from
May 20, 2024

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented May 20, 2024

更新 #80 实现,添加 loading 交互
例如 /package/zoningjs/files?version=2.0.20 加载事件比较久

  • ⌛ FileIcon 添加 isLoading 逻辑

Summary by CodeRabbit

  • New Features
    • Added a loading indicator to the FileTree component to improve user experience during data fetching.
    • Modified the Icon function in icon.tsx to accept default parameters for more flexible usage.

@elrrrrrrr elrrrrrrr added the enhancement New feature or request label May 20, 2024
@elrrrrrrr elrrrrrrr requested a review from fengmk2 May 20, 2024 09:44
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cnpmweb ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 9:47am

Copy link

coderabbitai bot commented May 20, 2024

Walkthrough

The update to the FileTree component introduces a loading indicator for improved user experience. It leverages the LoadingOutlined icon from @ant-design/icons, adding an isLoading prop to FileDiv, and utilizing isLoading from the useDirs hook in DirDiv. This enhancement allows the FileIcon component to display a loading icon conditionally.

Changes

File Path Change Summary
src/components/FileTree/index.tsx Imported LoadingOutlined from @ant-design/icons. Added isLoading prop to FileDiv and destructured isLoading from useDirs hook in DirDiv. Modified FileIcon to conditionally render a loading icon.

In the forest of code, a change has been made,
A loading icon now joins the parade.
With LoadingOutlined, the files spin and twirl,
Enhancing the tree in this digital world.
🌲✨🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1404458 and 4d8d6b4.
Files selected for processing (1)
  • src/components/FileTree/index.tsx (6 hunks)
Additional comments not posted (3)
src/components/FileTree/index.tsx (3)

68-74: LGTM! The isLoading prop is integrated correctly in FileDiv and passed appropriately to FileIcon.

Also applies to: 93-93


114-114: LGTM! The isLoading prop is used effectively in DirDiv to manage the loading state and passed correctly to FileDiv.

Also applies to: 121-121


137-137: LGTM! The conditional rendering based on the isLoading prop in FileIcon is implemented correctly.

Also applies to: 148-148

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4d8d6b4 and b59943b.
Files selected for processing (2)
  • src/components/FileTree/icon.tsx (1 hunks)
  • src/components/FileTree/index.tsx (6 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/components/FileTree/index.tsx
Additional comments not posted (1)
src/components/FileTree/icon.tsx (1)

22-22: LGTM! The getIconHelper function is well-implemented and uses caching effectively.

@fengmk2 fengmk2 merged commit 23f0299 into main May 20, 2024
6 checks passed
@fengmk2 fengmk2 deleted the loading-sub-dirs branch May 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants