fix: show every runscript log before run it #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Dec 27, 2018
| @@ -360,7 +360,7 @@ function* runPostInstallTasks(options) { | |||
| const postinstallScript = pkg.scripts.postinstall; | |||
| try { | |||
| if (installScript) { | |||
| options.console.info( | |||
| options.console.warn( | |||
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 92.91% 82.82% -10.1%
==========================================
Files 27 20 -7
Lines 1947 1560 -387
Branches 328 328
==========================================
- Hits 1809 1292 -517
- Misses 138 268 +130
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 92.91% 91.33% -1.58%
==========================================
Files 27 27
Lines 1947 1951 +4
Branches 328 328
==========================================
- Hits 1809 1782 -27
- Misses 138 169 +31
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Dec 28, 2018
|
3.19.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.