Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: force clean #41

Merged
merged 5 commits into from
Oct 25, 2023
Merged

feat: force clean #41

merged 5 commits into from
Oct 25, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Oct 24, 2023 •
edited
Loading

#38 二次安装时，判断当前是否有对应挂载点

  • rapid list 不再判断 nydusd 启动状态
  • clean 方法添加 force 参数，开启时执行 umount -f
  • 新增 clean [path] 参数
  • hdiutil detach 统一使用 umount 实现

@elrrrrrrr elrrrrrrr added the enhancement New feature or request label Oct 24, 2023
killagu
killagu reviewed Oct 24, 2023
View reviewed changes
packages/cli/lib/index.js Outdated Show resolved Hide resolved
@elrrrrrrr elrrrrrrr marked this pull request as draft October 25, 2023 00:20
@elrrrrrrr elrrrrrrr marked this pull request as ready for review October 25, 2023 01:44
killagu
killagu approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 918c6e2 into master Oct 25, 2023
13 checks passed
@killagu killagu deleted the force-clean branch October 25, 2023 07:04
This was referenced Oct 30, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

@fengmk2 fengmk2 Awaiting requested review from fengmk2

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrrrrrrr @killagu