Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MAINTAINERS.md to CONTRIBUTORS.md #2057

Merged
merged 1 commit into from
May 31, 2024
Merged

Rename MAINTAINERS.md to CONTRIBUTORS.md #2057

merged 1 commit into from
May 31, 2024

Conversation

lixuna
Copy link
Collaborator

@lixuna lixuna commented May 31, 2024

Description

(name of issue/change)

Issues:

Refs: #NNN

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@lixuna lixuna requested review from taylor and Smitholi67 May 31, 2024 17:04
Smitholi67
Smitholi67 approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taylor taylor merged commit 5e226f4 into main May 31, 2024
@taylor taylor deleted the lixuna-patch-4 branch May 31, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smitholi67 Smitholi67 Smitholi67 approved these changes

@taylor taylor Awaiting requested review from taylor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lixuna @Smitholi67 @taylor