PULL_REQUEST_TEMPLATE.md: Add template #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangamcse
suggested changes
May 27, 2018
PULL_REQUEST_TEMPLATE.md
Outdated
| Thanks for your contribution! | ||
|
|
||
| Please take a quick look at those things down there. They're quite important. | ||
| Really! We wrote them for you. Yes you! With utmost care. Read them. |
There was a problem hiding this comment.
Hey, I know you have followed main repositories' template but it will look nicer if add a , between Yes and you IMO. 😃
sks444
approved these changes
May 28, 2018
|
ack 744e9da |
|
These silly tasks are for newcomers. If you are bored, do https://gitlab.com/coala/mobans/issues/2 , or create an issue to doe PULL_REQUEST_TEMPLATE.md as a moban. c.f. coala/meta#117 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188