IgnoreResultAction.py: Can use multiline_comment_delimiter as a fallback when comment_delimiter doesn't exist for a language

[hemangsk]

Initial discussion
Presently IgnoreResultAction.py uses comment_delimiter attribute to add ignore comments.
Some bears such as CSSLintBear have multiline_comment_delimiter attribute and not a comment_delimiter and therefore this causes failure to add ignore comment in css files.

Steps for reproduction:

1. Create file style.css

.low{
font-family:Roboto;
color:white;
}

2. Execute coala --bears CSSLintBear --files style.css

style.css
|   1| .low•{
|    | [NORMAL] CSSLintBear:
|    | Rule doesn't have all its properties in alphabetical order. (order-alphabetical)
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 2
|    | Please enter a value for the parameter 'language' (No description given.): css
[ERROR][14:26:06] Failed to execute the action IgnoreResultAction with error: 'comment_delimiter'.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 2
|    | Please enter a value for the parameter 'language' (No description given.): css
[ERROR][14:26:13] Failed to execute the action IgnoreResultAction with error: 'comment_delimiter'.
|    | *0: Do nothing
|    |  1: Open file(s)
|    |  2: Add ignore comment
|    | Enter number (Ctrl-D to exit): 2
|    | Please enter a value for the parameter 'language' (No description given.): scss
[ERROR][14:26:19] Failed to execute the action IgnoreResultAction with error: .

It is asking for the parameter 'language' from the user and then if there is no language found with name css, it returns

Failed to execute the action IgnoreResultAction with error: 'comment_delimiter'.

Possible Solution
We can add an option in IgnoreResultAction,

 if language has attribute comment delimiter then
    use comment_delimiter to add ignore comment
 elif language.hasattr(multiline_comment_delimiter) and not language.hasattr(comment_delimiter):
   use multilime_comment_delimiter to add ignore comment
else
  print ("We don't have a comment_delimiter for this language, What would you like to wrap the ignore comment in ?")
   take comment delimiter as an input from user

[nemani]

Can I try this?

[nemani]

Unless @hemangsk wants to do it...

[Makman2]

here you go :)

[nemani]

Sorry I just saw this now 🙈

[hemangsk]

Hey @nemaniarjun please feel free to ping me if there's any hindrance in reproducing this issue

[nemani]

So I have successfully added the ignore comment using the multiline comment delimiter.
But the result is not ignored.
So should I create another issue for that? or continue in this one?

[nemani]

Ignore the above comment :P Found the mistake.

[nemani]

Error in rultor? This did not get closed? @sils

[sils]

you had a # before the URL, typo

[nemani]

Okay will keep in mind 👍