Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tested node versions to 14, 16, and 18 #347

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 20, 2022

No description provided.

@coveralls
Copy link

coveralls commented May 20, 2022

Pull Request Test Coverage Report for Build 2361219349

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 91.76%

Totals Coverage Status
Change from base Build 2350308957: 0.08%
Covered Lines: 2840
Relevant Lines: 3053

💛 - Coveralls

@JKRhb
Copy link
Member Author

JKRhb commented May 21, 2022

@Apollon77 Hmm, seems like Node 18 causes some problems. I think there was a multicast-related API change that causes that?

@Apollon77
Copy link
Collaborator

puuhh ... ist it that "network family parameter change"? Will be reverted in 18.2 as it seems

@JKRhb
Copy link
Member Author

JKRhb commented May 22, 2022

puuhh ... ist it that "network family parameter change"? Will be reverted in 18.2 as it seems

Oh, you mean this one, right? nodejs/node#41431 (comment)

@Apollon77
Copy link
Collaborator

Apollon77 commented May 22, 2022

yes, should be reverted in node.js 18.2

@Apollon77
Copy link
Collaborator

nope ... not fixed by 18.2

@JKRhb
Copy link
Member Author

JKRhb commented May 23, 2022

nope ... not fixed by 18.2

I think the number of errors reduced from 10 to 4, though, so we're at least halfway there ;)

@JKRhb
Copy link
Member Author

JKRhb commented Jun 18, 2022

The latest version of Node 18 seems to have solved the issue :) So I would merge this PR.

@JKRhb JKRhb merged commit 5ebd2c4 into coapjs:master Jun 18, 2022
@JKRhb JKRhb deleted the node-version branch June 18, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants