added EmbeddingStatistics and tests #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @nec4! i'd be glad to review this! do you have someone else working w/ you who you'd like to onboard into our process? in that case, they can can co-review it with me- let me know! |
|
Hey Brooke! I think my remote was set up incorrectly - I meant to push this to my personal fork. I think I accidentally set the PR to target the cgnet master instead of forked master (not sure if this is the best practice). Implementation of embedding-dependent stuff is still ongoing so this PR is not yet finished. You are welcome to review now (if you want to). |
added 2 commits
November 2, 2020 12:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development:
Checks:
nosetestsThese changes set the foundation for embedding-dependent priors and general embedding-dependent statistics.