Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Too much space after webR block in RevealJS #102

Closed
dlsun opened this issue Nov 17, 2023 · 2 comments
Closed

[Bug]: Too much space after webR block in RevealJS #102

dlsun opened this issue Nov 17, 2023 · 2 comments
Labels
t: bug Something isn't working
Milestone

Comments

@dlsun
Copy link

dlsun commented Nov 17, 2023

Bug description

There is so much whitespace after a webR block in RevealJS that any remaining content overflows off the initial viewport.

For example, the output of the minimal Quarto document below is:

Screenshot 2023-11-17 at 12 13 20 AM

Steps to reproduce

You should be able to reproduce it with the following minimal Quarto document.

---
title: Testing
engine: knitr
format: 
  revealjs:
    resources:
    - webr-serviceworker.js
    - webr-worker.js
webr:
  channel-type: "automatic"
filters:
  - webr
---

## Slide with webR {.scrollable}

```{webr-r}
2 + 3
```

This text should appear right below the webR block, but is way
down in 0.4.0.

Compare the results of running:

  • quarto add coatless/quarto-webr@0.3.8
  • quarto add coatless/quarto-webr (production)

Your environment

  • MacOS Sonoma 14.0
  • Using RStudio

Quarto check output

No response

@dlsun dlsun added t: bug Something isn't working s: triage-needed New bug report that needs to be classified. labels Nov 17, 2023
@dlsun
Copy link
Author

dlsun commented Nov 17, 2023

I think this bug is probably caused by #98 but am not sure

coatless added a commit that referenced this issue Nov 17, 2023
Remove 100% height on interactive area
coatless added a commit that referenced this issue Nov 17, 2023
@coatless
Copy link
Owner

Fixed in #103.

Thanks! Sorry about that. Artifact of some font-size experiments

@coatless coatless removed the s: triage-needed New bug report that needs to be classified. label Nov 17, 2023
@coatless coatless added this to the 4.0 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants