fix: Bump syntect version to 1.7.0 and enable dump-load feature #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spoke with @trishume, and projects disabling syntect's default features may run into API-breaking changes with minor version releases. Bind crate to patch version to avoid further incidents. Syntect v1.7 adds dump-load and dump-load-rs options. Select dump-load since it's in syntect's default feature list and suspected to be compatible with v1.5. Consider switching to dump-load-rs after sufficient testing. Signed-off-by: Justin Charette <charetjc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spoke with @trishume, and projects disabling syntect's default features
may run into API-breaking changes with minor version releases. Bind
crate to patch version to avoid further incidents.
Syntect v1.7 adds dump-load and dump-load-rs options. Select dump-load
since it's in syntect's default feature list and suspected to be
compatible with v1.5. Consider switching to dump-load-rs after
sufficient testing.
Install successfully tested via:
Fixes #252