Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CI and using new aggregated sdk docs setup #18

Merged
merged 5 commits into from
Apr 1, 2021
Merged

Adding CI and using new aggregated sdk docs setup #18

merged 5 commits into from
Apr 1, 2021

Conversation

shahruk10
Copy link
Contributor

Closes #17

  • Updates doc src files for hugo version >= 0.69
  • Removes hugo and autogenerated docs from this repo in favor of using aggregated sdk-docs
  • Adds CI
  • Updates go version to 1.16.2; this required a fix to the TLS tests since Go >= 1.15 dropped support for verifying hostname/IP address in the Common Name field of a certificate. It now requires that the hostname be present in Subject Alternative Names (SAN) extension. See crypto/x509: Go 1.15 will break default connections to AWS RDS golang/go#39568 (comment)

@shahruk10
docs: remove hugo and generated docs
ec6e501 
  - Removed auto-generated docs from the repo as we now have
    a service that will compile and host those instead.

  - Remove hugo builds from Makefile because it will be applied
    directly by the hosting environment
@shahruk10
docs: remove docdock theme from repository
755736d
@shahruk10
docs: update docs to use hugo >= 0.69
533e568
@shahruk10
ci: add Jenkinsfile and Dockerfile for sdk-generator
bc867fe
@shahruk10
test: fixed go TLS tests by adding localhost to SAN in TLS certificate
48cd1db 
  - Go >= 1.15 dropped support for verifying hostname/IP address in
    the Common Name field of a certificate. It now requires that the
    hostname be present in Subject Alternative Names (SAN) extension.
    See golang/go#39568 (comment)
@render
Copy link

render bot commented Mar 25, 2021

Your Render PR Server URL is https://sdk-juzu-pr-18.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c1ec7slc2rvo88t73ej0.

@shahruk10 shahruk10 changed the base branch from master to shahruk/go-juzu March 25, 2021 17:10
mplooster
mplooster approved these changes Mar 25, 2021
View reviewed changes
Copy link

@mplooster mplooster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahruk10 shahruk10 merged commit 0a3f8e9 into shahruk/go-juzu Apr 1, 2021
@shahruk10 shahruk10 deleted the shahruk/ci-and-docs branch April 1, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplooster mplooster mplooster approved these changes

@happyalu happyalu Awaiting requested review from happyalu

@jhollowayj jhollowayj Awaiting requested review from jhollowayj

@renaissanceGeek renaissanceGeek Awaiting requested review from renaissanceGeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI to sdk-juzu
2 participants
@shahruk10 @mplooster