Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language server, and take some updates from the upstream repo #8

Merged
merged 3 commits into from
Jun 21, 2020

Conversation

davidroeca
Copy link
Collaborator

@davidroeca davidroeca commented Jun 12, 2020

Note that I updated the prettier config to be more similar to the one in https://github.com/sveltejs/language-tools so that it will be easy to bring in more patches as that repo gets more actively developed.

Closes: #1
Closes: #4
Closes: #5

@davidroeca
Copy link
Collaborator Author

currently broken. will update when fixed

@davidroeca
Copy link
Collaborator Author

there was an issue with the engine; should be functional now

@Jayphen
Copy link

Jayphen commented Jun 19, 2020

How can we get this merged? The current extension is quite out of date.

@davidroeca
Copy link
Collaborator Author

For vim-plug it would be:

Plug 'davidroeca/coc-svelte', { 'do': 'yarn install --frozen-lockfile && yarn build' }

For other plugin managers, something similar

@callmiy
Copy link

callmiy commented Jun 20, 2020

Hi @davidroeca
Thanks for this pull request. I installed the extension directly from your repo.

How you get it working with typescript? I can get svelte to work in vscode using the instructions from this blog post, but same would not work with coc-svelte.

Your help will be highly appreciated.

@davidroeca
Copy link
Collaborator Author

@Kanmii try this doc. If it's still not working, it would help me to see an example reproduction

@callmiy
Copy link

callmiy commented Jun 20, 2020

Whao! Thanks @davidroeca. Works like a charm with the template pointed to in the doc file. I will try to make it work with a sapper project I'm working on.

Make it a great weekend!
Thanks

@iamcco iamcco merged commit d5838d3 into coc-extensions:master Jun 21, 2020
@iamcco
Copy link
Member

iamcco commented Jun 21, 2020

Sorry for the late reply, great work!!

@orta
Copy link

orta commented Jun 25, 2020

Anyone here is welcome to pop into the svelte language-tools chat room on discord if you want to chat with the folks working on the LSP too, nice work all

@davidroeca
Copy link
Collaborator Author

Sounds good! Happy to hop in on the discussion

@johnnynia
Copy link

This still hasn't been published or has it? I've also noticed a seemingly more active fork published on npmjs.com as coc-svelte-fork by @jjrdn. And @davidroeca proposed helping to maintain this repo on Discord. Would it be someshow possible to merge and synergize these efforts?

Just asking after having struggled with my vim svelte setup for the last couple days 😅

@davidroeca
Copy link
Collaborator Author

davidroeca commented Aug 6, 2020

@johnnynia have you had issues using this? Open an issue if so, or request an update. I do not use svelte actively enough yet to know when things really need to be updated. The language-tools repo is incredibly active so it’s hard to keep up especially since this isn’t part of that monorepo. I am still open to moving it in and that would make this a bit easier to maintain, though there are a few key differences in how much is supported in coc/vim and in vscode (syntax highlighting, for example, is supported in the vscode plugin but not here).

I had set up a fork for myself a while back but I opened a pull request here so that I could contribute back to the coc/vim community. I hope that another person who decides to maintain a fork will also consider this too.

Personally I am unclear why this would need to be published to npm, since you don’t need it on npm to use it or install it with coc. Is there a particular use case I am missing here?

@johnnynia
Copy link

@davidroeca Thanks for your reply! You're right, it does not have to be published on npm (just tested it on a coworker's computer). Somehow coc would not update the extension to the last version what let me to the wrong assumption that it needs to be published, and therefore I've installed it via Plug. So no issue here :-)

I share your hopes regarding joining contribution efforts in order to keep up with the pace in language-tools repo. Unfortunately I'm not yet too familiar with coc (as I have just proven 😅).

@iamcco
Copy link
Member

iamcco commented Aug 6, 2020

@davidroeca it had been published to npm after merged. I'm also not use svelte actively enough to tracking upstream since my work turn to use angular.

@davidroeca davidroeca deleted the update-lang-server branch November 26, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants