Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: add python3-pcp for RHEL images #6775

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

jelly
Copy link
Member

@jelly jelly commented Aug 22, 2024

The Python rewrite of cockpit-pcp is underway and to help development and testing add the new runtime dependency.

@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: a792f516c851: [no-test] images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous cockpituous changed the title WIP: a792f516c851: [no-test] images: add python3-pcp for RHEL images WIP: 18739c5e7033: [no-test] images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 18739c5e7033: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: 30dc2cdbc9f5: [no-test] images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 30dc2cdbc9f5: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: 1c6734d1f103: [no-test] images: add python3-pcp for RHEL images Aug 22, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 1c6734d1f103: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 22, 2024
@martinpitt
Copy link
Member

Just to make sure, you only want this as a runtime dependency, not a build-time one (BuildRequires:), right? I.e. pytest should be able to skip the pcp unit tests. (This is fine for me)

Tests are an absolute disaster.. 😢 this is definitively a "yell very loudly on Monday" thing.

@jelly
Copy link
Member Author

jelly commented Aug 22, 2024

Just to make sure, you only want this as a runtime dependency, not a build-time one (BuildRequires:), right? I.e. pytest should be able to skip the pcp unit tests. (This is fine for me)

Yes

Tests are an absolute disaster.. 😢 this is definitively a "yell very loudly on Monday" thing.

Ugh, kinda feared that. Should I split it up?

@martinpitt
Copy link
Member

@ptoscano Can you please have a look at the three sub-man regressions on RHEL 10? sub-man, sub-man-cockpit, and on rhel-9-5 ? Same test, and same failed assertion, but slightly different failure mode -- one screenshot has a popup alert ("Failure in name resolution"), the other doesn't.

@jelly I take a look at the c10s failures first, they also break TF runs. As this is such a mess, I suggest to only take one image refresh here, and handle the other images in separate PRs.

@martinpitt
Copy link
Member

Most of the centos-10 regressions are explained by the new kernel breaking journal logging. I reported this as https://issues.redhat.com/browse/RHEL-56025 . This has a reasonably straightforward workaround, however, it's not the full story as the TF failures show. However, let's do another refresh with that fix, and see where we land.

@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: cf01acbe6f77: [no-test] images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: cf01acbe6f77: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: 2f72e99c2582: [no-test] images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 2f72e99c2582: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: cb3b0c2ed45c: [no-test] images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: cb3b0c2ed45c: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: ad8d88adb13a: [no-test] images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: ad8d88adb13a: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@martinpitt
Copy link
Member

OK, there's no sense in trying to hack around this. This is broken beyond our reach. https://issues.redhat.com/browse/RHEL-54549 is likely a duplicate and points to some more root causes. So this is just broken for now. I'll still keep the cleanup commit, and let's consider RHEL 10 as "broken" and rebuilds as blocked. Let's instead try to refresh rhel 9.5 so that @jelly has something to play with for pcp?

@cockpituous cockpituous changed the title images: add python3-pcp for RHEL images WIP: 9d957618a417: [no-test] images: add python3-pcp for RHEL images Aug 26, 2024
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 9d957618a417: [no-test] images: add python3-pcp for RHEL images images: add python3-pcp for RHEL images Aug 26, 2024
@martinpitt
Copy link
Member

So it's just that sub-man regression now. @ptoscano can you please have a look?

@martinpitt martinpitt mentioned this pull request Aug 27, 2024
3 tasks
@ptoscano
Copy link
Contributor

So it's just that sub-man regression now. @ptoscano can you please have a look?

It's due to recent changes in insights-client that appeared few days ago in RHEL composes; see candlepin/subscription-manager-cockpit#80 for a longer explanation and hopefully a fix (reviewer welcome, my JS is non-existent).

jelly and others added 3 commits August 29, 2024 11:39
The Python rewrite of cockpit-pcp is underway and to help development
and testing add the new runtime dependency.
zero-disk.setup already does that.
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo!

@martinpitt martinpitt merged commit d5f547a into main Aug 29, 2024
16 checks passed
@martinpitt martinpitt deleted the rhel-images-python-pcp branch August 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants