Commits on Sep 8, 2020

1. Ensure application CSS has priority over library CSS …

   Import our application CSS as the very last thing, so that it can
   properly override  PatternFly variables. Before, our application CSS
   could land in the first third of dist/index.css *before* PatternFly's
   definitions, so that the latter overrode the former [1].
   
   This is a long-standing bug in mini-css-extract-plugin ([2] and
   countless things that point to it) with `NODE_ENV=production` builds.
   
   As a workaround, make sure that app.scss is the absolutely last imported
   CSS, instead of "almost last". It is still conceptually correct for the
   application CSS to be able to override patternfly-4-overrides.scss.
   
   [1] https://github.com/martinpitt/performance-graphs/issues/10
   [2] webpack-contrib/mini-css-extract-plugin#188

   

   martinpitt committed Sep 8, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for fd9c45f
   • Browse repository at this point

   Copy the full SHA

   fd9c45f View commit details

   Browse the repository at this point in the history