-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Remove `database_exists?` method from `CockroachDBAdapter`, the original method is fine. - Exclude a test that will be fixed in Rails 7.2
- Loading branch information
Showing
5 changed files
with
20 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 14 additions & 2 deletions
16
test/excludes/ActiveRecord/PostgresqlTransactionNestedTest.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,14 @@ | ||
exclude :test_deadlock_raises_Deadlocked_inside_nested_SavepointTransaction, "Causes CI to hand. Skip while debugging." | ||
exclude :test_unserializable_transaction_raises_SerializationFailure_inside_nested_SavepointTransaction, "Causes CI to hand. Skip while debugging." | ||
|
||
# > In CRDB SERIALIZABLE, reads block on in-progress writes for | ||
# > as long as those writes are in progress. However, PG does | ||
# > not have this "read block on write" behavior, and so rather | ||
# > than allowing the left-hand-side to execute, it must instead | ||
# > abort that transaction. Both are valid ways to implement SERIALIZABLE. | ||
# | ||
# See discussion: https://github.com/cockroachdb/activerecord-cockroachdb-adapter/pull/333 | ||
message = "SERIALIZABLE transactions are different in CockroachDB." | ||
|
||
exclude :test_deadlock_raises_Deadlocked_inside_nested_SavepointTransaction, message | ||
exclude :test_unserializable_transaction_raises_SerializationFailure_inside_nested_SavepointTransaction, message | ||
exclude :test_SerializationFailure_inside_nested_SavepointTransaction_is_recoverable, message | ||
exclude :test_deadlock_inside_nested_SavepointTransaction_is_recoverable, message |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# TODO: Rails 7.2 remove this exclusion | ||
exclude "test_#undefine_attribute_methods_undefines_alias_attribute_methods", "The test will be fixed in 7.2 (https://github.com/rails/rails/commit/a0993f81d0450a191da1ee35282f60fc2899135c)" |