Skip to content

Commit

Permalink
bind range conn failure
Browse files Browse the repository at this point in the history
  • Loading branch information
BuonOmo committed Sep 2, 2024
1 parent 2847291 commit b23cb90
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 26 deletions.
25 changes: 0 additions & 25 deletions test/cases/sanitize_test.rb

This file was deleted.

11 changes: 10 additions & 1 deletion test/excludes/SanitizeTest.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
exclude :test_bind_enumerable, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
exclude :test_named_bind_variables, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
exclude :test_sanitize_sql_array_handles_named_bind_variables, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
exclude :test_bind_range, "This test is overridden for CockroachDB because this adapter adds quotes to numeric values."

require "support/copy_cat"

# CRDB quotes ranges, like Trilogy.
CopyCat.copy_methods(self, self, :test_bind_range) do
def on_sym(node)
return unless node in [:sym, :TrilogyAdapter]
replace(node.loc.expression, ":CockroachDBAdapter")
end
end

0 comments on commit b23cb90

Please sign in to comment.