El Juego

.editorconfig

@@ -0,0 +1,7 @@
+root = true
+
+[*.rb]
+indent_style = space
+indent_size = 2
+trim_trailing_whitespace = true
+insert_final_newline = true

.zed/settings.json

@@ -0,0 +1,8 @@
+// Folder-specific settings
+//
+// For a full list of overridable settings, and general information on folder-specific settings,
+// see the documentation: https://docs.zed.dev/configuration/configuring-zed#folder-specific-settings
+{
+  "hard_tabs": false,
+  "tab_size": 2
+}

NOTES.md

@@ -0,0 +1,32 @@
+# Feedback
+
+- the whole `eval` thing in the gemfile should really be avoided (see "fix/gemspec-shinanigan")
+- contributing documentation is sparse and old. Some steps should be simplified
+- lots of conditions (global variables) in tests and gemfile, reduces readability
+  a lot
+- the test suite is way too long (and not really working as a whole on my laptop)
+- https://www.cockroachlabs.com/docs/v23.1/build-a-ruby-app-with-cockroachdb-activerecord
+  > tutorial shows you how build a
+- https://www.cockroachlabs.com/product/sql/ links to an outdated version of the doc
+- https://www.cockroachlabs.com/docs/stable/build-a-ruby-app-with-cockroachdb-activerecord.html?filters=local#step-4-run-the-code
+  the DATABASE_URL variable is wrong (missing the database name)
+
+# TODO
+
+- finish this tutorial https://www.cockroachlabs.com/docs/v23.1/build-a-ruby-app-with-cockroachdb-activerecord?filters=ccloud
+- https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/259
+
+
+# Work done
+
+2023-06-16: 1h40 installation and reading.
+2023-06-19: 40m read about cockroach, watch and try out ruby examples
+2023-06-20: 2h debugging tests locally
+2023-06-20: 1h respond to #251 and still tests debugging..
+2023-06-21: 1h ran the full test suite. Update contributing file
+2023-06-21: 50m try to figure out where to put the monkey patch for index hint
+2023-06-21: 30m figure it out, offer a rough design in the PR https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/266#issuecomment-1602858210
+2023-06-22: 1h Fix local installation for good (more than 1h, but mixed with local configuration..)
+2023-06-23: 10m open pr for #251
+2023-06-26: 10m exchange on #266 design
+2023-06-26: 2h start coding the optimizer hint thingy.

TODO

@@ -0,0 +1,6 @@
+- dump custom schema correctly
+
+test_dump_foreign_key_targeting_different_schema
+SchemaTest#test_with_schema_prefixed_table_name
+SchemaTest#test_with_schema_search_path
+SchemaTest#test_with_schema_prefixed_capitalized_table_name

foo.dot

@@ -0,0 +1,52 @@
+digraph "Arel" {
+node [width=0.375,height=0.25,shape=record];
+296440 [label="<f0>Arel::Nodes::SelectStatement"];
+296460 [label="<f0>Array"];
+296480 [label="<f0>Arel::Nodes::SelectCore"];
+296500 [label="<f0>Arel::Nodes::JoinSource"];
+247680 [label="<f0>Arel::Table"];
+247700 [label="<f0>String|<f1>posts"];
+296520 [label="<f0>Array"];
+296540 [label="<f0>Array"];
+296560 [label="<f0>Arel::Attributes::Attribute"];
+296580 [label="<f0>Arel::Nodes::SqlLiteral|<f1>*"];
+296600 [label="<f0>Array"];
+296620 [label="<f0>Arel::Nodes::Equality"];
+296640 [label="<f0>Arel::Attributes::Attribute"];
+247860 [label="<f0>String|<f1>foo"];
+296660 [label="<f0>ActiveRecord::Relation::QueryAttribute"];
+3 [label="<f0>Integer|<f1>1"];
+296680 [label="<f0>Array"];
+296700 [label="<f0>Array"];
+4 [label="<f0>NilClass|<f1>"];
+296720 [label="<f0>Array"];
+296740 [label="<f0>Array"];
+296440 -> 296460 [label="cores"];
+296460 -> 296480 [label="0"];
+296480 -> 296500 [label="source"];
+296500 -> 247680 [label="left"];
+247680 -> 247700 [label="name"];
+296500 -> 296520 [label="right"];
+296480 -> 296540 [label="projections"];
+296540 -> 296560 [label="0"];
+296560 -> 247680 [label="relation"];
+296560 -> 296580 [label="name"];
+296480 -> 296600 [label="wheres"];
+296600 -> 296620 [label="0"];
+296620 -> 296640 [label="left"];
+296640 -> 247680 [label="relation"];
+296640 -> 247860 [label="name"];
+296620 -> 296660 [label="right"];
+296660 -> 3 [label="value_before_type_cast"];
+296480 -> 296680 [label="windows"];
+296480 -> 296700 [label="groups"];
+296480 -> 4 [label="comment"];
+296480 -> 296720 [label="havings"];
+296480 -> 4 [label="set_quantifier"];
+296480 -> 4 [label="optimizer_hints"];
+296440 -> 4 [label="limit"];
+296440 -> 296740 [label="orders"];
+296440 -> 4 [label="offset"];
+296440 -> 4 [label="lock"];
+296440 -> 4 [label="with"];
+}

lib/active_record/connection_adapters/cockroachdb_adapter.rb

@@ -513,7 +513,9 @@ def column_definitions(table_name)
                ORDER BY a.attnum
           SQL
 
+          pp fields
           crdb_fields = crdb_column_definitions(table_name)
+          pp crdb_fields
 
           # Use regex comparison because if a type is an array it will
           # have [] appended to the end of it.