fix: support multiple databases #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
force-pushed
the
fix/251/no-monkeypatch-pg
branch
2 times, most recently
from
bf3358f
to
5561f3f
Compare
We used to monkeypatch freely some classes. However, Rails is now supporting multiple databases, and these patches are in the way of this usage. Fixes #251
BuonOmo
force-pushed
the
fix/251/no-monkeypatch-pg
branch
from
5561f3f
to
af5a662
Compare
|
@rafiss I think further testing would require way too much time now and in tests. I'd stay as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following and replacing #271 now that I have repository access.