chore: unexclude tests fixed in CRDB #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuonOmo
force-pushed
the
chore/unblock-tests
branch
2 times, most recently
from
05bbb92
to
125e832
Compare
|
Seems to me like we can now merge this one, can't we ? (note that you would have to change the branch protection rule pattern) |
Closed
rafiss
force-pushed
the
chore/unblock-tests
branch
from
125e832
to
0735ae6
Compare
rafiss
force-pushed
the
chore/unblock-tests
branch
from
0735ae6
to
eb2f077
Compare
rafiss
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cockroachdb/cockroach#110144
@rafiss I can force push the commit again to re-run the test once crdb is updated!