Remove overriden primary_keys method #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We can use the PostgreSQL Adapter's definition.
* In the PostgreSQL Adapter, PostgreSQLColumn#serial? checks to see if the
column's default function is sequence. In CockroachDB, serial columns will
have a default function that uses unique_rowid().
* ActiveRecord allows for tables to exist without primary keys. Databases like
PostgreSQL support this behavior, but CockroachDB does not. If a table is
created without a primary key, CockroachDB will add a rowid column to serve
as its primary key. This breaks a lot of ActiveRecord's assumptions so we'll
treat tables with rowid primary keys as if they didn't have primary keys at
all.
* In PostgreSQL, serial columns are backed by integer columns. They're also
backed by integer columns in CockroachDB, but integer columns are the same
size as PostgreSQL's bigints. Therefore, bigint? will be true for serial
columns in the CockroachDB Adpater while it will be false in the PostgreSQL
Adapter.
* The ActiveRecord test creates a table with a serial primary key expecting
the serial info to be included in the schema dump. That info will not be
included in the schema dump because CockroachDB treats serial and bigserial
columns as bigserial columns. ActiveRecord defaults to bigserial primary
keys so it doesn't need to include that info in the schema dump.
integer test
* The AR test fails because CockroachDB's INT type translates to PostgreSQL's
bigint type. Although the test table is created with an integer primary key,
it will come back as BIGINT from CockroachDB. So the schema dump will show
it as a bigint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now remove the overridden
primary_keysand use the PostgreSQL Adapter's definition.This PR also includes a couple of other primary key changes.
PostgreSQLColumn#serial?so it checks forunique_rowid()instead of a sequence. 986dc9drowidas a default primary key because it breaks a lot of ActiveRecord's assumptions about tables that don't have primary keys. 5dab156The rest of the changes address tests that were failing in the ActiveRecord primary keys test. Failing tests have been excluded and replaced with appropriate tests for CockroachDB.