Skip more schema tests #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as custom schemas are not supported in CockroachDB
* NULLS FIRST and NULLS LAST aren't implemented in CockroachDB and therefore
won't be included in any schema dumps.
* Operator classes on indexes are not supported in CockroachDB
|
It looks like nobody has asked for operator class support in cockroachdb. Can you file an issue and point to it, or tell me what it should say? |
|
I opened cockroachdb/cockroach#47420. I wasn't sure how to label it and stuff, so let me know if it needs any changes. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these schema tests are skipped because custom schemas are not supported in CockroachDB (cockroachdb/cockroach#26443).
We're skipping a few more tests for different reasons
I wasn't able to find any documentation or issues on operator classes. Is this documented anywhere or is it a new problem?