testserver: fix tenant-client cert arguments #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
fix-tenant-cert
branch
2 times, most recently
from
74a9176
to
947f51d
Compare
knz
approved these changes
Nov 16, 2021
rafiss
changed the title
Since cockroachdb/cockroach#71248 the server address must be passed in as a positional argument. Technically, the version check makes cockroach-go tenant servers not work for commits between a0c04c620ddb67cf44265eaef61bcd38c13e4fe7 and d7569dae28d405437f5af670346d45c2d6deb42a, but I think this is an acceptable breakage since those are unreleased commits.
rafiss
force-pushed
the
fix-tenant-cert
branch
from
947f51d
to
9ea4a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs cockroachdb/cockroach#71387
Since cockroachdb/cockroach#71248 the server
address must be passed in as a positional argument.
Technically, the version check makes cockroach-go tenant servers not
work for commits between a0c04c620ddb67cf44265eaef61bcd38c13e4fe7 and
d7569dae28d405437f5af670346d45c2d6deb42a, but I think this is an
acceptable breakage since those are unreleased commits.