Fix the development environment for linux, darwin and M1 arch #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prafull01
force-pushed
the
development-environment
branch
3 times, most recently
from
77a34fb to
413fb38
Compare
prafull01
force-pushed
the
development-environment
branch
2 times, most recently
from
059c867 to
5b19028
Compare
prafull01
force-pushed
the
development-environment
branch
from
5b19028 to
0f651cc
Compare
prafull01
force-pushed
the
development-environment
branch
7 times, most recently
from
c05e2d0 to
6538d7c
Compare
prafull01
force-pushed
the
development-environment
branch
from
6538d7c to
239607f
Compare
udnay
approved these changes
Nov 4, 2024
| sha256 = "a874d479f183f9e4c19a5c69b44955fabd2e250b467d2d9f0641ae91a82ddbea", | ||
| urls = ["https://storage.googleapis.com/cert-manager-testing-assets/kube-apiserver-1.17.3_darwin_amd64"], | ||
| sha256 = "800eedc293bcc72eb962df3e8006d7106790ca583a4ea5c107453bab3bf859b4", | ||
| urls = ["https://storage.googleapis.com/cockroach-operator-testing-assets/kube-apiserver-1.24.2_darwin_amd64"], |
There was a problem hiding this comment.
We should update kube-apiserver_linux_amd64 as well.
There was a problem hiding this comment.
Fixed it. Also, gen_rule doesn't have any such condition. I might have to look deeper to move fetch_preflight to some other target which have platform specific option.
prafull01
force-pushed
the
development-environment
branch
3 times, most recently
from
8803436 to
7c67d14
Compare
|
Will merge when test passes |
prafull01
force-pushed
the
development-environment
branch
8 times, most recently
from
f4f12f1 to
0d10dfb
Compare
prafull01
force-pushed
the
development-environment
branch
2 times, most recently
from
51be942 to
ed20896
Compare
prafull01
force-pushed
the
development-environment
branch
4 times, most recently
from
36e752f to
f157001
Compare
prafull01
force-pushed
the
development-environment
branch
from
f157001 to
4d8a6c9
Compare
udnay
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code to support development on Darwin amd64 and arm64 architectures.