Merge #41432

41432: roachprod: fatal nodes on stats mismatch r=bdarnell a=tbg

The clearrange is the only test running with this option, and it fired.
Increase our coverage of stats mismatches to hopefully find a better
repro target.

See
#38720 (comment).

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>

pkg/cmd/roachprod/install/cockroach.go

@@ -249,6 +249,9 @@ func (r Cockroach) Start(c *SyncedCluster, extraArgs []string) {
 			fmt.Sprintf(" export ROACHPROD=%d%s && ", nodes[i], c.Tag) +
 			"GOTRACEBACK=crash " +
 			"COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 " +
+			// Turn stats mismatch into panic, see:
+			// https://github.com/cockroachdb/cockroach/issues/38720#issuecomment-539136246
+			"COCKROACH_FATAL_ON_STATS_MISMATCH=true " +
 			c.Env + " " + binary + " start " + strings.Join(args, " ") +
 			" >> " + logDir + "/cockroach.stdout.log 2>> " + logDir + "/cockroach.stderr.log" +
 			" || (x=$?; cat " + logDir + "/cockroach.stderr.log; exit $x)"