Skip to content

Commit

Permalink
Merge #41195
Browse files Browse the repository at this point in the history
41195: storage: fix incorrect listener on concurrent AddSST setting r=dt a=dt

Copy/paste mistake meant that the wrong setting was being used to trigger the re-read of the setting on-update.

Release note (bug fix): fix bug that prevented changes to kv.bulk_io_write.concurrent_addsstable_requests from taking effect.

Release justification: very small, low-risk fix for user-visible bug in existing code.

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
  • Loading branch information
craig[bot] and dt committed Sep 30, 2019
2 parents 603694c + 3255968 commit 29c2464
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/storage/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ func NewStore(
s.limiters.ConcurrentAddSSTableRequests = limit.MakeConcurrentRequestLimiter(
"addSSTableRequestLimiter", int(addSSTableRequestLimit.Get(&cfg.Settings.SV)),
)
importRequestsLimit.SetOnChange(&cfg.Settings.SV, func() {
addSSTableRequestLimit.SetOnChange(&cfg.Settings.SV, func() {
s.limiters.ConcurrentAddSSTableRequests.SetLimit(int(addSSTableRequestLimit.Get(&cfg.Settings.SV)))
})
s.limiters.ConcurrentRangefeedIters = limit.MakeConcurrentRequestLimiter(
Expand Down

0 comments on commit 29c2464

Please sign in to comment.