Skip to content

Commit

Permalink
roachtest: standardize start options for UA and non UA
Browse files Browse the repository at this point in the history
More concretly, build `StartOpts` based on roachtest's implementation
of `DefaultStartOpts`, which includes creating a default backup
schedule on start.

Epic: none

Release note: None
  • Loading branch information
renatolabs committed Feb 15, 2024
1 parent dde28e4 commit 3d1995a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/option/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func DefaultStartSingleNodeOpts() StartOpts {
// DefaultStartVirtualClusterOpts returns StartOpts for starting an external
// process virtual cluster with the given tenant name and SQL instance.
func DefaultStartVirtualClusterOpts(tenantName string, sqlInstance int) StartOpts {
startOpts := StartOpts{RoachprodOpts: roachprod.DefaultStartOpts()}
startOpts := DefaultStartOpts()
startOpts.RoachprodOpts.Target = install.StartServiceForVirtualCluster
startOpts.RoachprodOpts.VirtualClusterName = tenantName
startOpts.RoachprodOpts.SQLInstance = sqlInstance
Expand All @@ -71,7 +71,7 @@ func DefaultStartVirtualClusterOpts(tenantName string, sqlInstance int) StartOpt
// DefaultStartSharedVirtualClusterOpts returns StartOpts for starting a shared
// process virtual cluster with the given tenant name.
func DefaultStartSharedVirtualClusterOpts(tenantName string) StartOpts {
startOpts := StartOpts{RoachprodOpts: roachprod.DefaultStartOpts()}
startOpts := DefaultStartOpts()
startOpts.RoachprodOpts.Target = install.StartSharedProcessForVirtualCluster
startOpts.RoachprodOpts.VirtualClusterName = tenantName
return startOpts
Expand Down

0 comments on commit 3d1995a

Please sign in to comment.