Skip to content

Commit

Permalink
sql: refactor InternalExecutor on EvalCtx
Browse files Browse the repository at this point in the history
Minor refactor to remove duplicate InternalExecutor definition
on EvalCtx and in the tree package.

We already have 2 interface declarations for InternalExecutor
in sql and sqlutil, this refactor hopefully makes the dependencies
a little more clear.

Release note: None
  • Loading branch information
RichardJCai committed Oct 11, 2021
1 parent 7d2431d commit 4832a18
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions pkg/ccl/streamingccl/streamingutils/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ go_library(
"//pkg/jobs",
"//pkg/jobs/jobspb",
"//pkg/kv",
"//pkg/security",
"//pkg/sql/sem/tree",
"//pkg/sql/sessiondata",
"//pkg/streaming",
"//pkg/util/hlc",
"//pkg/util/protoutil",
Expand Down
1 change: 1 addition & 0 deletions pkg/sql/faketreeeval/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ go_library(
importpath = "github.com/cockroachdb/cockroach/pkg/sql/faketreeeval",
visibility = ["//visibility:public"],
deps = [
"//pkg/kv",
"//pkg/security",
"//pkg/sql/parser",
"//pkg/sql/pgwire/pgcode",
Expand Down
1 change: 0 additions & 1 deletion pkg/sql/row/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ go_test(
"//pkg/sql/rowenc",
"//pkg/sql/rowinfra",
"//pkg/sql/sem/tree",
"//pkg/sql/sqlutil",
"//pkg/storage",
"//pkg/testutils",
"//pkg/testutils/serverutils",
Expand Down
1 change: 0 additions & 1 deletion pkg/sql/sem/builtins/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ go_library(
"//pkg/sql/sqlerrors",
"//pkg/sql/sqlliveness",
"//pkg/sql/sqltelemetry",
"//pkg/sql/sqlutil",
"//pkg/sql/types",
"//pkg/streaming",
"//pkg/util",
Expand Down

0 comments on commit 4832a18

Please sign in to comment.