Skip to content

Commit

Permalink
sql: remove TODO about #13642
Browse files Browse the repository at this point in the history
This issue already fixed.

Release note: None
  • Loading branch information
hueypark committed Apr 24, 2020
1 parent 3db3496 commit 5527cb5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion pkg/sql/sem/builtins/math_builtins.go
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ func decimalLogFn(
logFn func(*apd.Decimal, *apd.Decimal) (apd.Condition, error), info string,
) tree.Overload {
return decimalOverload1(func(x *apd.Decimal) (tree.Datum, error) {
// TODO(mjibson): see #13642
switch x.Sign() {
case -1:
return nil, errLogOfNegNumber
Expand Down
1 change: 0 additions & 1 deletion pkg/sql/sem/tree/eval.go
Original file line number Diff line number Diff line change
Expand Up @@ -5526,7 +5526,6 @@ func (c *CallbackValueGenerator) Close() {}

// Sqrt returns the square root of x.
func Sqrt(x float64) (*DFloat, error) {
// TODO(mjibson): see #13642
if x < 0.0 {
return nil, errSqrtOfNegNumber
}
Expand Down

0 comments on commit 5527cb5

Please sign in to comment.