Skip to content

Commit

Permalink
Merge #98417
Browse files Browse the repository at this point in the history
98417: lint: skip TestLowercaseFunctionNames under --short r=irfansharif a=irfansharif

It takes ~350s on my M1, and is the lone straggler.

    $ dev lint --short
    ...
        --- PASS: TestLint/TestEnvutil (1.51s)
        --- PASS: TestLint/TestCopyrightHeaders (0.62s)
        --- PASS: TestLint/TestCrlfmt (8.05s)
        --- PASS: TestLint/TestGofmtSimplify (9.66s)
        --- PASS: TestLint/TestMissingLeakTest (5.48s)
        --- PASS: TestLint/TestLowercaseFunctionNames (357.81s)
    PASS

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
  • Loading branch information
craig[bot] and irfansharif committed Mar 11, 2023
2 parents 3a7818b + a8f5cb7 commit 5b2a567
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/testutils/lint/lint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ func TestLint(t *testing.T) {
pkgVar, pkgSpecified := os.LookupEnv("PKG")

t.Run("TestLowercaseFunctionNames", func(t *testing.T) {
skip.UnderShort(t)
t.Parallel()
reSkipCasedFunction, err := regexp.Compile(`^(Binary file.*|[^:]+:\d+:(` +
`query error .*` + // OK when in logic tests
Expand Down

0 comments on commit 5b2a567

Please sign in to comment.