Skip to content

Commit

Permalink
Merge #39168
Browse files Browse the repository at this point in the history
39168: logictestccl: fix zone failures under stress r=solongordon a=solongordon

The 'zone' logic test was failing under stress due to a race between
gossiping zone config changes and running explain plans. As suggested by
an existing comment, I added the "retry" option to more tests to account
for this potential race.

Fixes #38864

Release note: None

Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
  • Loading branch information
craig[bot] and solongordon committed Aug 1, 2019
2 parents da56c79 + 98b302f commit 8282250
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/ccl/logictestccl/testdata/logic_test/zone
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ scan · ·
· table t@secondary
· spans /10-/11

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down Expand Up @@ -70,7 +70,7 @@ scan · ·
· table t@tertiary
· spans /10-/11

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down Expand Up @@ -128,7 +128,7 @@ scan · ·
· table t@primary
· spans /10-/10/#

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down Expand Up @@ -221,7 +221,7 @@ scan · ·
· table t@tertiary
· spans /10-/11

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down Expand Up @@ -271,7 +271,7 @@ scan · ·
· table t@secondary
· spans /10-/11

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down Expand Up @@ -362,7 +362,7 @@ scan · ·
· table t36642@tertiary
· spans /10-/11

query T
query T retry
EXPLAIN (OPT, CATALOG) SELECT * FROM t
----
TABLE t
Expand Down

0 comments on commit 8282250

Please sign in to comment.