Skip to content

Commit

Permalink
Merge #98049
Browse files Browse the repository at this point in the history
98049: roachtest: skip restore/pause test on gce build r=stevendanna a=msbutler

Currently, the new restore roachtests fail if the backup is not stored on the same cloud provider that the test runs. For this reason, the new restore/pause test should only run on aws. This patch ensures this.

Fixes #98033

Release note: none

Co-authored-by: Michael Butler <butler@cockroachlabs.com>
  • Loading branch information
craig[bot] and msbutler committed Mar 6, 2023
2 parents 14b43be + ffdd2aa commit 8dc3728
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/cmd/roachtest/tests/restore.go
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,11 @@ func registerRestore(r registry.Registry) {
Cluster: withPauseSpecs.hardware.makeClusterSpecs(r),
Timeout: withPauseSpecs.timeout,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {

if c.Spec().Cloud != withPauseSpecs.backup.cloud {
// For now, only run the test on the cloud provider that also stores the backup.
t.Skip("test configured to run on %s", withPauseSpecs.backup.cloud)
}
c.Put(ctx, t.Cockroach(), "./cockroach")
c.Start(ctx, t.L(), option.DefaultStartOptsNoBackups(), install.MakeClusterSettings())
m := c.NewMonitor(ctx)
Expand Down

0 comments on commit 8dc3728

Please sign in to comment.