Skip to content

Commit

Permalink
sql/logictest: clarify retry comment
Browse files Browse the repository at this point in the history
Release note: None
  • Loading branch information
mgartner committed Mar 16, 2023
1 parent dbbf20d commit 98d1add
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/sql/logictest/logic.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,7 @@ import (
// duration. If the test succeeds at any time during that period, it
// is considered successful. Otherwise, it is a failure. See
// testutils.SucceedsSoon for more information. If run with the
// -rewrite flag, inserts a 2s sleep before executing the query
// once.
// -rewrite flag, the query will be run only once after a 2s sleep.
// - async: runs the query asynchronously, marking it as a pending
// query using the label parameter as a unique name, to be completed
// and validated later with "awaitquery". This is intended for use
Expand Down
2 changes: 2 additions & 0 deletions pkg/sql/logictest/testdata/logic_test/retry
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ SELECT nextval('s')

# Unit test for bug #95664, retry on a query producing an error should
# try again and succeed if err doesn't happen again.
# NOTE: This test will fail when the --rewrite flag is used because the query
# will only be run once.
query I retry
SELECT
CASE subq.val
Expand Down

0 comments on commit 98d1add

Please sign in to comment.