Skip to content

Commit

Permalink
changefeedccl: log more details when returning with non-retryable errors
Browse files Browse the repository at this point in the history
The `%v` and `%+v` were switched from what I intended in the line that
logs retryable errors and the one that handles non-retryable errors.

Release note: None
  • Loading branch information
danhhz committed Apr 23, 2019
1 parent ec4728a commit ac74be9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/ccl/changefeedccl/changefeed_stmt.go
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,11 @@ func (b *changefeedResumer) Resume(
return nil
}
if !IsRetryableError(err) {
log.Warningf(ctx, `CHANGEFEED job %d returning with error: %v`, jobID, err)
log.Warningf(ctx, `CHANGEFEED job %d returning with error: %+v`, jobID, err)
return err
}

log.Warningf(ctx, `CHANGEFEED job %d encountered retryable error: %+v`, jobID, err)
log.Warningf(ctx, `CHANGEFEED job %d encountered retryable error: %v`, jobID, err)
if metrics, ok := execCfg.JobRegistry.MetricsStruct().Changefeed.(*Metrics); ok {
metrics.ErrorRetries.Inc(1)
}
Expand Down

0 comments on commit ac74be9

Please sign in to comment.