Skip to content

Commit

Permalink
sql: bump workmem size to avoid sqllite flakes on index/1000 tests
Browse files Browse the repository at this point in the history
Below ~70k these tests would flake like so:

```
pq: streamer budget: memory budget exceeded: 38112 bytes requested, 57344 currently allocated, 76801 bytes in budget
```

Fixes: #89635

Release note: None
  • Loading branch information
cucaroach committed Oct 17, 2022
1 parent ca643e2 commit ba4e08f
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pkg/sql/logictest/logic.go
Original file line number Diff line number Diff line change
Expand Up @@ -1494,8 +1494,13 @@ func (t *logicTest) newCluster(
var randomWorkmem int
if t.rng.Float64() < 0.5 && !serverArgs.DisableWorkmemRandomization {
// Randomize sql.distsql.temp_storage.workmem cluster setting in
// [10KiB, 100KiB) range.
randomWorkmem = 10<<10 + t.rng.Intn(90<<10)
// [10KiB, 100KiB) range for normal tests and even bigger for sqlite
// tests.
if *Bigtest {
randomWorkmem = 100<<10 + t.rng.Intn(90<<10)
} else {
randomWorkmem = 10<<10 + t.rng.Intn(90<<10)
}
}

// Set cluster settings.
Expand Down

0 comments on commit ba4e08f

Please sign in to comment.