Skip to content

Commit

Permalink
Merge #93292
Browse files Browse the repository at this point in the history
93292: upgrade: fix pkg godoc r=andreimatei a=andreimatei

Remove an extra line so that godoc considers it a pkg comment.

Release note: None
Epic: None

Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
  • Loading branch information
craig[bot] and andreimatei committed Dec 9, 2022
2 parents 742ebde + f15cb32 commit c471947
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/upgrade/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ corresponding to version 23.1.<foo> doing the `ALTER TABLE` for old cluster, and
probably a backfill for the table rows. Say that a permanent upgrade like
`addRootUser()` has code inserting into system.users. If it were not for this
guarantee, the `addRootUser()` code could not be changed to do:
INSERT INTO system.users (..., foo) ....
INSERT INTO system.users (..., foo) ....
If this query was run in a cluster being upgraded from 22.2 to 23.1, it would
fail because the column doesn't exist yet (as the upgrade adding it has not yet
run). This guarantee says that, if addRootUser() runs, it can expect the
bootstrap schema that has "foo".
*/

package upgrade

0 comments on commit c471947

Please sign in to comment.