Skip to content

Commit

Permalink
logictest: minor improvements
Browse files Browse the repository at this point in the history
Clarify that the test.progress field refers to statements executed, not
"tests".

Release note: None
  • Loading branch information
andreimatei committed Nov 4, 2021
1 parent f84b8e7 commit e4aff7f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/sql/logictest/logic.go
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,7 @@ type logicTest struct {
// new one, but keep some shared resources across the entire test. An example
// would be an IO directory used throughout the test.
testCleanupFuncs []func()
// progress holds the number of tests executed so far.
// progress holds the number of statements executed so far.
progress int
// failures holds the number of tests failed so far, when
// -try-harder is set.
Expand Down Expand Up @@ -3042,7 +3042,7 @@ func (t *logicTest) success(file string) {
now := timeutil.Now()
if now.Sub(t.lastProgress) >= 2*time.Second {
t.lastProgress = now
t.outf("--- progress: %s: %d statements/queries", file, t.progress)
t.outf("--- progress: %s: %d statements", file, t.progress)
}
}

Expand Down Expand Up @@ -3413,7 +3413,7 @@ func RunLogicTestWithDefaultConfig(
now := timeutil.Now()
if now.Sub(progress.lastProgress) >= 2*time.Second {
progress.lastProgress = now
lt.outf("--- total progress: %d statements/queries", progress.total)
lt.outf("--- total progress: %d statements", progress.total)
}
})
}
Expand Down

0 comments on commit e4aff7f

Please sign in to comment.