sql: desugar "TIMESTAMP WITH TIME ZONE" to "TIMESTAMPTZ"

Prior to this patch the canonical name for the timestamptz type in
CockroachDB was "TIMESTAMP WITH TIME ZONE" with spaces and all
glorious 24 characters.

This is unfortunate because this is a pretty common type, and is
moreover used to disambiguate the return type of `now()` and thus will
be emitted pretty often in distsql physical plans. Having such a long
type name is unnecessary and indeed adds 50%+ storage, communication
and parsing overhead for every occurrence of this type in
distsql plans.

This patch shortens the canonical CockroachDB name to "TIMESTAMPTZ".

The representation of the type in introspection tables (pg_catalog,
information_schema) is unaffected.

Release note: None

docs/RFCS/20170317_settings_table.md

@@ -55,7 +55,7 @@ A new system.settings table, keyed by string settings names would be created.
 CREATE TABLE system.settings (
   name STRING PRIMARY KEY,
   value STRING,
-  updated TIMESTAMP WITH TIME ZONE DEFAULT NOW() NOT NULL,
+  updated TIMESTAMPTZ DEFAULT NOW() NOT NULL,
   valueType char NOT NULL DEFAULT 's',
 )
 ```

pkg/cli/dump_test.go

@@ -204,6 +204,7 @@ func TestDumpRandom(t *testing.T) {
 			fr real,
 			d date,
 			m timestamp,
+			mtz timestamptz,
 			n interval,
 			o bool,
 			e decimal,
@@ -212,7 +213,7 @@ func TestDumpRandom(t *testing.T) {
 			u uuid,
 			ip inet,
 			j json,
-			PRIMARY KEY (rowid, i, si, bi, f, fr, d, m, n, o, e, s, b, u, ip)
+			PRIMARY KEY (rowid, i, si, bi, f, fr, d, m, mtz, n, o, e, s, b, u, ip)
 		);
 		SET extra_float_digits = 3;
 	`, nil); err != nil {
@@ -287,6 +288,7 @@ func TestDumpRandom(t *testing.T) {
 				f, // fr
 				d,
 				m,
+				m,
 				[]byte(n), // intervals come out as `[]byte`s
 				o,
 				[]byte(e), // decimals come out as `[]byte`s
@@ -296,14 +298,14 @@ func TestDumpRandom(t *testing.T) {
 				[]byte(ip.String()),
 				[]byte(j.String()),
 			}
-			if err := conn.Exec("INSERT INTO d.t VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16)", vals); err != nil {
+			if err := conn.Exec("INSERT INTO d.t VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17)", vals); err != nil {
 				t.Fatal(err)
 			}
 			generatedRows = append(generatedRows, vals[1:])
 		}
 
 		check := func(table string) {
-			q := fmt.Sprintf("SELECT i, si, bi, f, fr, d, m, n, o, e, s, b, u, ip, j FROM %s ORDER BY rowid", table)
+			q := fmt.Sprintf("SELECT i, si, bi, f, fr, d, m, mtz, n, o, e, s, b, u, ip, j FROM %s ORDER BY rowid", table)
 			nrows, err := conn.Query(q, nil)
 			if err != nil {
 				t.Fatal(err)

pkg/cli/testdata/dump/row

@@ -73,7 +73,7 @@ CREATE TABLE t (
 	ip INET NULL,
 	j JSONB NULL,
 	ary STRING[] NULL,
-	tz TIMESTAMP WITH TIME ZONE NULL,
+	tz TIMESTAMPTZ NULL,
 	e1 DECIMAL(2) NULL,
 	e2 DECIMAL(2,1) NULL,
 	s1 STRING(1) NULL,

pkg/sql/coltypes/timedate.go

@@ -61,7 +61,7 @@ func (node *TTimestampTZ) TypeName() string { return "TIMESTAMPTZ" }
 
 // Format implements the ColTypeFormatter interface.
 func (node *TTimestampTZ) Format(buf *bytes.Buffer, f lex.EncodeFlags) {
-	buf.WriteString("TIMESTAMP WITH TIME ZONE")
+	buf.WriteString(node.TypeName())
 }
 
 // TInterval represents an INTERVAL type

pkg/sql/copy_in_test.go

@@ -56,7 +56,7 @@ func TestCopyNullInfNaN(t *testing.T) {
 			e DECIMAL NULL,
 			u UUID NULL,
 			ip INET NULL,
-			tz TIMESTAMP WITH TIME ZONE NULL
+			tz TIMESTAMPTZ NULL
 		);
 	`); err != nil {
 		t.Fatal(err)
@@ -151,7 +151,7 @@ func TestCopyRandom(t *testing.T) {
 			b BYTES,
 			u UUID,
 			ip INET,
-			tz TIMESTAMP WITH TIME ZONE
+			tz TIMESTAMPTZ
 		);
 		SET extra_float_digits = 3; -- to preserve floats entirely
 	`); err != nil {

pkg/sql/logictest/testdata/logic_test/alter_column_type

@@ -16,12 +16,12 @@ ALTER TABLE t ALTER s TYPE BYTES, ALTER sl TYPE STRING(6), ALTER ts TYPE TIMESTA
 query TTBTTTB colnames
 SHOW COLUMNS FROM t
 ----
-column_name  data_type                 is_nullable  column_default  generation_expression  indices      is_hidden
-s            BYTES                     true         NULL            ·                      {}           false
-sl           STRING(6)                 true         NULL            ·                      {}           false
-t            TIME                      true         NULL            ·                      {}           false
-ts           TIMESTAMP WITH TIME ZONE  true         NULL            ·                      {}           false
-rowid        INT                       false        unique_rowid()  ·                      {"primary"}  true
+column_name  data_type    is_nullable  column_default  generation_expression  indices      is_hidden
+s            BYTES        true         NULL            ·                      {}           false
+sl           STRING(6)    true         NULL            ·                      {}           false
+t            TIME         true         NULL            ·                      {}           false
+ts           TIMESTAMPTZ  true         NULL            ·                      {}           false
+rowid        INT          false        unique_rowid()  ·                      {"primary"}  true
 
 query TTTT
 SELECT * FROM t

pkg/sql/logictest/testdata/logic_test/collatedstring

@@ -280,7 +280,7 @@ SELECT '2017-01-10 16:05:50.734049+00:00' COLLATE en::TIMESTAMP
 2017-01-10 16:05:50.734049 +0000 +0000
 
 query T
-SELECT '2017-01-10 16:05:50.734049+00:00' COLLATE en::TIMESTAMP WITH TIME ZONE
+SELECT '2017-01-10 16:05:50.734049+00:00' COLLATE en::TIMESTAMPTZ
 ----
 2017-01-10 16:05:50.734049 +0000 +0000
 

pkg/sql/logictest/testdata/logic_test/datetime

@@ -33,7 +33,7 @@ statement ok
 CREATE TABLE u (
   a BIGINT PRIMARY KEY,
   b TIMESTAMP,
-  c TIMESTAMP WITH TIME ZONE,
+  c TIMESTAMPTZ,
   d DATE,
   e INTERVAL
 )
@@ -176,7 +176,7 @@ BEGIN TRANSACTION
 statement ok
 CREATE TABLE kv (
   k CHAR PRIMARY KEY,
-  v TIMESTAMP WITH TIME ZONE
+  v TIMESTAMPTZ
 )
 
 statement ok
@@ -336,9 +336,9 @@ statement ok
 CREATE TABLE ex (
   k BIGINT PRIMARY KEY,
   element STRING,
-  input TIMESTAMP WITH TIME ZONE,
+  input TIMESTAMPTZ,
   extract_result INT,
-  date_trunc_result TIMESTAMP WITH TIME ZONE
+  date_trunc_result TIMESTAMPTZ
 )
 
 statement ok
@@ -907,17 +907,17 @@ statement ok
 CREATE TABLE tz (
   a INT PRIMARY KEY,
   b TIMESTAMP,
-  c TIMESTAMP WITH TIME ZONE,
+  c TIMESTAMPTZ,
   d TIMESTAMPTZ
 )
 
 query TTBTTTB
 SHOW COLUMNS FROM tz
 ----
-a  INT                       false  NULL  ·  {"primary"}  false
-b  TIMESTAMP                 true   NULL  ·  {}           false
-c  TIMESTAMP WITH TIME ZONE  true   NULL  ·  {}           false
-d  TIMESTAMP WITH TIME ZONE  true   NULL  ·  {}           false
+a  INT          false  NULL  ·  {"primary"}  false
+b  TIMESTAMP    true   NULL  ·  {}           false
+c  TIMESTAMPTZ  true   NULL  ·  {}           false
+d  TIMESTAMPTZ  true   NULL  ·  {}           false
 
 statement ok
 INSERT INTO tz VALUES