Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestDockerCLI/test_sql_mem_monitor.tcl is skipped #106462

Closed
rafiss opened this issue Jul 7, 2023 · 0 comments · Fixed by #106566
Closed

TestDockerCLI/test_sql_mem_monitor.tcl is skipped #106462

rafiss opened this issue Jul 7, 2023 · 0 comments · Fixed by #106566
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). db-cy-23 skipped-test T-sql-queries SQL Queries Team

Comments

@rafiss
Copy link
Collaborator

rafiss commented Jul 7, 2023 •
edited by cockroach-jira-scripts
Loading

This tracks unskipping the test. It was skipped in #94882

Assigning to SQL Queries as per https://cockroachlabs.slack.com/archives/CA8H95NUU/p1686322600592149?thread_ts=1686315607.940919&cid=CA8H95NUU

Jira issue: CRDB-29571
@rafiss rafiss added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). skipped-test T-sql-queries SQL Queries Team labels Jul 7, 2023
@rafiss rafiss added the branch-master Failures and bugs on the master branch. label Jul 7, 2023
@rafiss rafiss mentioned this issue Jul 8, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 8, 2023
@rafiss
Merge #106463
43c26ae 
106463: interactive_tests: preserve demo logs in tests r=knz a=rafiss

Now we pass in the --log-dir option so that logs are saved when the test fails. Otherwise, the demo command does not log.

This also unskips two tests that should be working now.

informs #96450
informs #102257
informs #100319
informs #106462
informs #106461
informs #96797
informs #96239


Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@rafiss rafiss mentioned this issue Jul 9, 2023
Merged
@yuzefovich yuzefovich self-assigned this Jul 11, 2023
@yuzefovich yuzefovich mentioned this issue Jul 11, 2023
Merged
@craig craig bot closed this as completed in 5d7a1a2 Jul 12, 2023
@yuzefovich yuzefovich mentioned this issue Jul 12, 2023
Merged
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). db-cy-23 skipped-test T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli/interactive_tests: re-enable sql_mem_monitor test yuzefovich/cockroach
2 participants
@rafiss @yuzefovich