-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: allow specifying namespaced types #16395
Comments
@jordanlewis Do you mind explaining if this is a compatibility issue related to ORMs, GUIs or just everything in general? Trying to get a sense for how often and in what situations this issue would occur. |
It's a compatibility issue related to any client program that uses this syntax. So far I've only observed it to be used by |
@rohany did this get fixed? |
This is possible now, but some work will need to be done for type resolution on these virtual schemas. |
It would be cool to get just the |
Yeah it seems pretty easy. I'll take a look this week. |
Fixes cockroachdb#16395. Release note (sql change): Allows for referencing static data types under the `pg_catalog` qualification like `pg_catalog.int`.
Fixes cockroachdb#16395. Release note (sql change): Allows for referencing static data types under the `pg_catalog` qualification like `pg_catalog.int`.
Fixes cockroachdb#16395. Release note (sql change): Allows for referencing static data types under the `pg_catalog` qualification like `pg_catalog.int`.
49307: sql: add support for virtual schema qualified types r=rohany a=rohany Fixes #16395. Release note (sql change): Allows for referencing static data types under the `pg_catalog` qualification like `pg_catalog.int`. 49530: sql: support max/min aggregates on collated strings r=rohany a=rohany Fixes #45846. Fixes #46685. This PR allows for performing the max/min aggregations on collated strings. Currently, our aggregates would not support container types like `AnyCollatedString`. This PR extends the aggregates infrastructure in DistSQL that caused the limitation to allow for container types, which unblocks #48370. Release note (sql change): Support the max/min aggregations on collated strings. 49567: cloud: bump version to 20.1.1 r=dt a=dt Release note: none. 49574: roachtest: get bigger machines for alterpk-tpcc-250 r=yuzefovich a=yuzefovich The test has been failing for a while now because we're operating very close to memory limit. Usually, 3.3.2.6 expensive check query ends up crashing the node, sometimes it hits SQL memory limit. I've been staring at it for a while, but there is a discrepancy between the memory usage reported in runtime stats in logs and the usage that shows up in heap profiles (for example, I could see 8GB in the former and 3GB in the latter), and I couldn't figure out where that gaps goes. I don't think spending any more time on this issue is worthwhile, so this commit bumps the machine type from cpu-16 to cpu-32 which doubles available RAM from 14.4 to 28.8. Fixes: #48428. Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Fixes cockroachdb#16395. Release note (sql change): Allows for referencing static data types under the `pg_catalog` qualification like `pg_catalog.int`.
psql
emits the following query when you try to describe a table with\d foo
:We currently don't support specifying types with namespaces, such as
pg_catalog.text
. We may want to add a trivial amount of support for this kind of specification to improve compatibility.The text was updated successfully, but these errors were encountered: