Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: panic while attempting to rename primary index #24774

Closed
knz opened this issue Apr 13, 2018 · 0 comments · Fixed by #24776
Closed

sql: panic while attempting to rename primary index #24774

knz opened this issue Apr 13, 2018 · 0 comments · Fixed by #24776
Assignees
@knz
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Milestone
2.0.x

Comments

@knz
Copy link
Contributor

knz commented Apr 13, 2018 •
edited
Loading

Found while investigating #24475.

ALTER INDEX kv@"primary" RENAME TO pk

crashes with

panic while executing 1 statements: ALTER INDEX _@_ RENAME TO _; caused by index with id = 1 does not exist

goroutine 453 [running]:
runtime/debug.Stack(0x292b660, 0xc4207ad540, 0x3)
        /usr/local/go/src/runtime/debug/stack.go:24 +0xa7
github.com/cockroachdb/cockroach/pkg/util/log.ReportPanic(0x292b660, 0xc4207ad540, 0xc420784000, 0x24b2820, 0xc42721d050, 0x1)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/util/log/crash_reporting.go:212 +0xa5
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).closeWrapper(0xc425381000, 0x292b660, 0xc4207ad540, 0x224ba60, 0xc426791380)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:521 +0x2d5
github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func2(0xc425381000, 0x292b660, 0xc4207ad540)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:489 +0x61
panic(0x224ba60, 0xc426791380)
        /usr/local/go/src/runtime/panic.go:505 +0x229
github.com/cockroachdb/cockroach/pkg/sql/sqlbase.(*TableDescriptor).RenameIndexDescriptor(0xc426a75500, 0xc42673b960, 0x7, 0x100000001, 0xc4267912f0, 0x1, 0x1, 0xc42673b978, 0x1, 0x2, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/sqlbase/structured.go:1913 +0x24e
github.com/cockroachdb/cockroach/pkg/sql.(*planner).RenameIndex(0xc4253813f0, 0x292b720, 0xc4266f1e00, 0xc4269d59a0, 0xc4269d59a0, 0x0, 0x0, 0x0)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/rename_index.go:80 +0x46f
github.com/cockroachdb/cockroach/pkg/sql.(*planner).newPlan(0xc4253813f0, 0x292b720, 0xc4266f1e00, 0x292daa0, 0xc4269d59a0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan.go:698 +0x709
github.com/cockroachdb/cockroach/pkg/sql.(*planner).makePlan(0xc4253813f0, 0x292b720, 0xc4266f1e00, 0x292daa0, 0xc4269d59a0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan.go:296 +0x100
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispatchToExecutionEngine(0xc425381000, 0x292b720, 0xc4266f1e00, 0x292daa0, 0xc4269d59a0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:551 +0xb1b
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmtInOpenState(0xc425381000, 0x292b720, 0xc4266f1e00, 0x292daa0, 0xc4269d59a0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:368 +0xa8c
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execStmt(0xc425381000, 0x292b720, 0xc4266f1e00, 0x292daa0, 0xc4269d59a0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:83 +0x358
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run(0xc425381000, 0x292b660, 0xc4207ad540, 0xc4202f6b30, 0x0, 0x0)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:917 +0x1d7a
github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn(0xc4208e8a00, 0x292b660, 0xc4207ad540, 0x0, 0x0, 0xc425b01028, 0x4, 0xc425b01015, 0xd, 0x2913860, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:491 +0xfae
github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl.func3(0xc4208e8a00, 0x292b660, 0xc4207ad540, 0xc42522c1c0, 0x5400, 0x15000, 0xc42090c3d0, 0xc4202f6b30, 0xc4202f6b20, 0xc4202e9010, ...)
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:260 +0x10c
created by github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).serveImpl
        /data/home/kena/src/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:259 +0xf27
@knz knz added this to the 2.0.x milestone Apr 13, 2018
@knz knz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 13, 2018
@knz knz self-assigned this Apr 13, 2018
@knz knz mentioned this issue Apr 13, 2018
Merged
craig bot pushed a commit that referenced this issue Apr 16, 2018
@knz
Merge #24776
ee1117e 
24776: sql: fix ALTER INDEX RENAME on primary index r=knz a=knz

Fixes #24774.

ALTER INDEX ... RENAME would crash if issued on the primary index.

Release note (bug fix): `ALTER INDEX ... RENAME` can now be used on
the primary index.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig craig bot closed this as completed in #24776 Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
2.0.x
Development

Successfully merging a pull request may close this issue.

sql: fix ALTER INDEX RENAME on primary index knz/cockroach
1 participant
@knz