Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: TestLogGC is flaky #31371

Closed
tbg opened this issue Oct 15, 2018 · 1 comment
Closed

server: TestLogGC is flaky #31371

tbg opened this issue Oct 15, 2018 · 1 comment
Labels
C-test-failure Broken test (automatically or manually discovered).
Milestone
19.1

Comments

@tbg
Copy link
Member

tbg commented Oct 15, 2018

Seen in CI on an unrelated PR against master that didn't touch this code:

https://teamcity.cockroachdb.com/viewLog.html?buildId=966465&buildTypeId=Cockroach_UnitTests

@mvijaykarthik, could you take a look at this? I assume it will repro via make stress.


assertions.go:229: 
                        
	Error Trace:	server_systemlog_gc_test.go:140
	
	Error:		Should be true
	
	Messages:	Expected rowsGCd >= 2000, found 1001
	

assertions.go:237: 
                        
	Error Trace:	server_systemlog_gc_test.go:141
	
	Error:		Not equal: 0 (expected)
		        != 999 (actual)
	

assertions.go:237: 
                        
	Error Trace:	server_systemlog_gc_test.go:150
	
	Error:		Not equal: 5 (expected)
		        != 1004 (actual)
@tbg tbg added the C-test-failure Broken test (automatically or manually discovered). label Oct 15, 2018
@tbg tbg added this to the 2.2 milestone Oct 15, 2018
@mvijaykarthik
Copy link
Contributor

@tschottdorf sure

mvijaykarthik pushed a commit to mvijaykarthik/cockroach that referenced this issue Oct 15, 2018
server: Avoid using txn timestamp in gc test
e93d201 
Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes cockroachdb#31371.

Release note: None
@mvijaykarthik mvijaykarthik mentioned this issue Oct 16, 2018
Merged
craig bot pushed a commit that referenced this issue Oct 16, 2018
Merge #31420
24d6171 
31420: server: Avoid using txn timestamp in gc test r=tschottdorf a=mvijaykarthik

Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes #31371.

Release note: None

Co-authored-by: Vijay Karthik <vijay.karthik@rubrik.com>
@craig craig bot closed this as completed in #31420 Oct 16, 2018
tbg pushed a commit to tbg/cockroach that referenced this issue Oct 17, 2018
@tbg
server: Avoid using txn timestamp in gc test
3f0fac5 
Using transaction timstamp can lead to flaky tests.
Use constant timestamps while inserting events in rangelog
gc test.

Fixes cockroachdb#31371.

Release note: None
@tbg tbg mentioned this issue Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
2 participants
@tbg @mvijaykarthik