Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Postgres compatibility to support Flowable Engine: pg_catalog.set_config() #35108

Closed
drewdeally opened this issue Feb 21, 2019 · 2 comments
Assignees
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@drewdeally
Copy link

SELECT pg_catalog.set_config('search_path', '', false);

Build Tag:    v2.2.0-alpha.20190211
Build Time:   2019/02/07 23:44:57
Distribution: CCL
Platform:     linux amd64 (x86_64-unknown-linux-gnu)
Go Version:   go1.11.4
C Compiler:   gcc 6.3.0
Build SHA-1:  4bdf0ad7b3190e1836e311d2b05478e8cda0bfe6
Build Type:   release
andrewdeally@drew-test-0001:~$ ~/cockroach sql --insecure
# Welcome to the cockroach SQL interface.
# All statements must be terminated by a semicolon.
# To exit: CTRL + D.
#
# Server version: CockroachDB CCL v2.2.0-alpha.20190211 (x86_64-unknown-linux-gnu, built 2019/02/07 23:44:57, go1.11.4) (same version as client)
# Cluster ID: 5f191a3e-f77b-4fb4-8ad8-20d929dc5e27
# Organization: Cockroach Labs - Production Testing
#
# Enter \? for a brief introduction.
#
root@:26257/defaultdb> SELECT pg_catalog.set_config('search_path', '', false);
pq: unknown function: pg_catalog.set_config()
root@:26257/defaultdb> 

https://github.com/flowable/flowable-engine

@rolandcrosby
Copy link

As with #35109, I'm pretty sure this query was issued by pg_dump rather than the Flowable application.

@drewdeally
Copy link
Author

drewdeally commented Feb 21, 2019 via email

@awoods187 awoods187 added the A-sql-pgcompat Semantic compatibility with PostgreSQL label Mar 6, 2019
@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 6, 2019
craig bot pushed a commit that referenced this issue Mar 7, 2019
35091: sql: rearchitecture ALTER TABLE RENAME, add support for renaming constraints r=knz a=knz

Fixes #32555. For TypeORM compat, see discussion on #22298.

Release note (sql change): This patch changes RENAME COLUMN to become
a "table command", which can be used alongside other table commands in
a single ALTER TABLE statement. This makes it possible to e.g. atomically
add a computed column based on an existing column, and rename the
columns so that the computed column "replaces" the original column.

Release note (sql change): CockroachDB now supports ALTER TABLE RENAME
CONSTRAINT for compatibility with PostgreSQL. This feature is limited
to *named* constraints, where the name of the constraints is preserved
in the table metadata. This currently includes CHECK, UNIQUE and
FOREIGN KEY constraints, and does not include other
constraints (DEFAULT, NULL etc) otherwise supported by PostgreSQL. For
UNIQUE constraint, only supporting indexes that are not depended on by
views can be renamed.

35121: sql: add support for pg_catalog.{current_setting,set_config} r=knz a=knz

Fixes #35108. Needed for Flowable compatibility.

Release note (sql change): The SQL built-in functions
`pg_catalog.current_setting()` and `pg_catalog.set_config()` are now
supported for compatibility with PostgreSQL. Note that only
session-scoped configuration changes remain supported (`set_config(_,
_, false)`).

35359: roachtest: backup: use AOST time slightly in the past r=mjibson a=mjibson

Avoids problems where it's sometimes in the future according to the
AOST logic.

Fixes #34817

Release note: None

35371: sql: ensure column constraints are validated after SET for UPSERT r=knz a=knz

Fixes #35040.

Release note (bug fix): CockroachDB now properly applies column width
and nullability constraints on the result of conflict resolution in
UPSERT and INSERT ON CONFLICT.

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
@craig craig bot closed this as completed in #35121 Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

4 participants