Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with steps listed in CONTRIBUTING.md #36

Closed
sacheendra opened this issue Aug 21, 2014 · 2 comments
Closed

problem with steps listed in CONTRIBUTING.md #36

sacheendra opened this issue Aug 21, 2014 · 2 comments
Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.

Comments

@sacheendra
Copy link

The information given in CONTRIBUTING.md regarding getting and building doesn't seem to be working. A git clone of cockroach, then a git clone of rocksdb into _vendor and then running make seems to work. (after installing rocksdb dependencies ofcourse).
Does the file need an update?

@mikesun
Copy link

mikesun commented Aug 21, 2014

The preferred way of cloning the repo is via the go get command. There is a warning about missing files from RocksDB as go get will attempt to build and install the package as well. An alternative to suppress that error message is use go get -d, which will only download the repo.

After this you will need to run the ./bootstrap.sh script, which will take care of cloning the rocksdb submodule among other things. You can then run make, assuming you have installed required dependencies.

@sacheendra
Copy link
Author

Thanks for clarifying that. It would be nice if the doc showed the '-d' flag.

@tbg tbg mentioned this issue Dec 8, 2014
@tbg tbg closed this as completed Dec 8, 2014
soniabhishek added a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
Develop - Master (logger improvements + workflow builder)
pav-kv pushed a commit to pav-kv/cockroach that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.
Projects
None yet
Development

No branches or pull requests

4 participants