Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestLogic/crdb_internal/max_retry_counter test is flaky #38045

Closed
rytaft opened this issue Jun 5, 2019 · 2 comments · Fixed by #38051
Closed

TestLogic/crdb_internal/max_retry_counter test is flaky #38045

rytaft opened this issue Jun 5, 2019 · 2 comments · Fixed by #38051
Assignees
@knz

Comments

@rytaft
Copy link
Collaborator

rytaft commented Jun 5, 2019

I get this error after only a few seconds with make stress PKG=./pkg/sql/logictest/... TESTS='TestLogic//crdb_internal':

    --- FAIL: TestLogic/local-opt (0.01s)
        --- FAIL: TestLogic/local-opt/crdb_internal (0.26s)
            --- FAIL: TestLogic/local-opt/crdb_internal/max_retry_counter (0.02s)
                logic.go:2336: 
                     
                    testdata/logic_test/crdb_internal:434: SELECT key, (max_retries > 1), flags LIKE '!%' AS f
                      FROM crdb_internal.node_statement_statistics
                     WHERE application_name = 'test_max_retry'
                    ORDER BY key, f
                    expected:
                        SELECT crdb_internal.force_retry(_)  true  false
                        SELECT crdb_internal.force_retry(_)  true  true
                        SET application_name = DEFAULT       false false
                    but found (query options: "") :
                        SELECT crdb_internal.force_retry(_)  false  false
                        SELECT crdb_internal.force_retry(_)  false  true
                        SET application_name = DEFAULT       false  false
@rytaft
Copy link
Collaborator Author

rytaft commented Jun 5, 2019

cc @knz is it possible your latest change is related to this?

@rytaft rytaft changed the title crdb_internal/max_retry_counter test is flaky TestLogic/crdb_internal/max_retry_counter test is flaky Jun 5, 2019
@knz
Copy link
Contributor

knz commented Jun 6, 2019

yes, will fix

@knz knz self-assigned this Jun 6, 2019
@knz knz mentioned this issue Jun 6, 2019
Merged
craig bot pushed a commit that referenced this issue Jun 6, 2019
@knz
Merge #38051
608defd 
38051: sql: deflake TestLogic//crdb_internal/max_retry_counter r=jordanlewis a=knz

Fixes #38045.

The retry timeout was too short for `make stress`.
Instead this patch copies the timeout already used in the other
logic test file `txn`. I verified manually that `make stress`
is pleased with the new timeout.

Also fix a typo in the test comment.

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig craig bot closed this as completed in #38051 Jun 6, 2019
@jordanlewis jordanlewis mentioned this issue Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: deflake TestLogic//crdb_internal/max_retry_counter knz/cockroach
2 participants
@knz @rytaft