Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/cli: allow users to query for locality #38438

Closed
awoods187 opened this issue Jun 26, 2019 · 0 comments · Fixed by #39058
Closed

sql/cli: allow users to query for locality #38438

awoods187 opened this issue Jun 26, 2019 · 0 comments · Fixed by #39058
Assignees
@rohany
Labels
A-partitioning A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

Problem
Users need to look back at their initial start commands, look in the logs, or look at the data distribution page to retrieve locality. This can be error-prone and time-consuming.

Proposed Solution
In SQL, SHOW LOCALITY
In the CLI, Cockroach node returns locality
@awoods187 awoods187 added A-partitioning C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Jun 26, 2019
@awoods187 awoods187 added the A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect label Jun 26, 2019
@awoods187 awoods187 mentioned this issue Jul 15, 2019
Closed
16 tasks
@rohany rohany self-assigned this Jul 23, 2019
rohany added a commit to rohany/cockroach that referenced this issue Jul 29, 2019
@rohany
cli: Add locality information to cockroach node status command.
888813c 
Addressing cockroachdb#38438.

Release note (cli change): Add locality information to `cockroach
node status` command.
@rohany rohany mentioned this issue Jul 29, 2019
Merged
@rohany rohany mentioned this issue Jul 29, 2019
Merged
rohany added a commit to rohany/cockroach that referenced this issue Jul 29, 2019
@rohany
sql: Add SHOW LOCALITY command.
9838dab 
Addresses cockroachdb#38438.

`SHOW LOCALITY` returns the locality if it is set, or returns
`No locality set.`.

Release note (sql change): Add a `SHOW LOCALITY` command
in sql.
craig bot pushed a commit that referenced this issue Jul 29, 2019
@rohany @yuzefovich
Merge #39059 #39143
45a1f49 
39059: cli: Add locality information to cockroach node status command. r=rohany a=rohany

Addressing #38438.

Release note (cli change): Add locality information to `cockroach
node status` command.

39143: exec: not plan a redundant projection r=yuzefovich a=yuzefovich

In a degenerate case when the input operator produces the batches
that match the desired projection, we don't need to plan a
projection operator.

Release note: None

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
rohany added a commit to rohany/cockroach that referenced this issue Jul 29, 2019
@rohany
sql: Add SHOW LOCALITY command.
6bbd6fc 
Addresses cockroachdb#38438.

`SHOW LOCALITY` returns the locality of current node.

Release note (sql change): Add a `SHOW LOCALITY` command in sql.
craig bot pushed a commit that referenced this issue Jul 31, 2019
@rohany
Merge #39058
4051999 
39058: sql: Add SHOW LOCALITY command. r=rohany a=rohany

Addresses #38438.

`SHOW LOCALITY` returns the locality of the current node.

Release note (sql change): Add a `SHOW LOCALITY` command in sql.


Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig craig bot closed this as completed in #39058 Jul 31, 2019
@ericharmeling ericharmeling mentioned this issue Aug 13, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-partitioning A-sql-syntax Issues strictly related to the SQL grammar, with no semantic aspect C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: Add SHOW LOCALITY command. rohany/cockroach
2 participants
@rohany @awoods187