-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exec: finalize vectorize setting name and behavior #38620
Comments
There is a lot flakiness with "streaming" on by default on "fakedist" configurations. (Note that I override "vectorize" to off on all fakedist configs.) For example, when I run
I've seen similar failures on "fakedist" and "fakedist-disk". My only guess is that there are other "internal" queries that need to be executed in order to run the queries from the logic test files, and those "internal" ones are performed with default vectorize "streaming" setting and are probably accessing some systems tables, and that is broken somehow. Any ideas about that? cc @cockroachdb/sql-execution There is a bunch of other tests failing at the moment as well, but I have nothing to share about those (maybe it is the same underlying problem). |
38777: exec: add "auto" vectorize setting and make it default r=yuzefovich a=yuzefovich First commit renames Vectorize to VectorizeMode and removes "experimental_" prefix of vectorize setting. Second commit adds a fourth option "auto" to vectorize execution mode setting which plans the queries containing only streaming operators via the vectorized engine. This option is made a default one. Other options have been renamed: "on" -> "experimental_on" and "always" -> "experimental_always" to highlight for users the risk of using them. Fixes: #38620. Fixes: #38920. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Currently, the
experimental_vectorize
flag has 3 values: off, on and always. Off means never run with vectorize, and is the default. On means run everything that vectorized supports with vectorized. Always means run everything with vectorized, even the things that vectorized doesn't support.This issue tracks changing this setting to what it will look like in 19.2.
We need to change the name of the setting to remove the
experimental_
prefix, since anything that's going to be enabled by default shouldn't haveexperimental
in its name.Then, we need to add a new setting (maybe called on? auto? streaming?) that encodes the behavior of planning vectorized only if all operators are streaming operators.
The text was updated successfully, but these errors were encountered: