builtins: add width_bucket builtin function #38855
Labels
A-sql-builtins
SQL built-in functions and semantics thereof.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
E-easy
Easy issue to tackle, requires little or no CockroachDB experience
good first issue
Comments
jordanlewis
added
C-enhancement
|
I'll take on this |
|
@Inconnu08 great! Do let me know if you need pointers. |
|
@jordanlewis Hi! What is the actual status of this issue? |
|
@Russiancold Hey, I'm still working on this. But I'll let you know if I can't. :) |
|
@Inconnu08 Alright |
|
Hope you don't mind, but I took a stab at this since there wasn't much movement on it. #39263 @jordanlewis One thing I was unsure of is if it is necessary to have the overload for Numeric and Decimal? I created an overload for decimal and have been unable to find a situation where it doesn't work. |
kevinbarbour
added a commit
to kevinbarbour/cockroach
that referenced
this issue
Aug 2, 2019
Implements the width_bucket() builtin function Details on the Postgres implementation can be found here: https://www.postgresql.org/docs/11/functions-math.html Resolves cockroachdb#38855 Release note (sql change): add the width_bucket builtin function.
|
Ahh, I was almost halfway there. Stuck with the tests. Hence I didn't PR until completely done. But it's completely fine. :) |
kevinbarbour
added a commit
to kevinbarbour/cockroach
that referenced
this issue
Aug 2, 2019
Implements the width_bucket() builtin function Details on the Postgres implementation can be found here: https://www.postgresql.org/docs/11/functions-math.html Resolves cockroachdb#38855 Release note (sql change): add the width_bucket builtin function.
kevinbarbour
added a commit
to kevinbarbour/cockroach
that referenced
this issue
Aug 2, 2019
Implements the width_bucket() builtin function Details on the Postgres implementation can be found here: https://www.postgresql.org/docs/11/functions-math.html Resolves cockroachdb#38855 Release note (sql change): add the width_bucket builtin function.
craig bot
pushed a commit
that referenced
this issue
Aug 30, 2019
39263: sql: add width_bucket builtin r=jordanlewis a=barbourkd Implements the width_bucket() builtin function Details on the Postgres implementation can be found here: https://www.postgresql.org/docs/11/functions-math.html Resolves #38855 Release note (sql change): add the width_bucket builtin function. Co-authored-by: Kevin Barbour <barbourkd@vcu.edu> Co-authored-by: Kevin <kevinbarbourd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
width_bucketbuiltin is a super useful function that figures out where a number lies inside of a histogram given certain parameters.We should implement these. It's a pretty simple task that will boost compatibility (and help make
ALTER TABLE SPLIT BYa lot easier to run).This is a great issue for new contributors. The implementation of this builtin (well, each of its 3 overloads defined in the Postgres docs below) should live in
pkg/sql/sem/builtins/builtins.go.https://www.postgresql.org/docs/11/functions-math.html
The text was updated successfully, but these errors were encountered: