Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cockroach demo nodes feature #39780

Closed
rohany opened this issue Aug 20, 2019 · 1 comment · Fixed by #39786
Closed

Improve cockroach demo nodes feature #39780

rohany opened this issue Aug 20, 2019 · 1 comment · Fixed by #39786
Assignees
@rohany
Labels
A-demo A-partitioning C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@rohany
Copy link
Contributor

rohany commented Aug 20, 2019 •
edited
Loading

Right now, the cockroach demo takes in a --demo-locality argument which accepts a single locality tier for each node in the demo.

It would be better to allow for an arbitrary number of tiers to be assigned to each node, and to avoid abusing the parsing of the Locality flag, as brought up in comments on #39454.

A solution to do this is to use the syntax as follows, where colons separate the localities for each node.

./cockroach demo --nodes=3 --demo-localities=region=us-east1,az=1:region=us-east-1,az=2:region=us-east-1,az=3
@rohany rohany self-assigned this Aug 20, 2019
@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 20, 2019
@awoods187
Copy link
Contributor

Thanks @andreimatei for point this out. Excited about demo getting more and more useful.

@rohany rohany mentioned this issue Aug 21, 2019
Merged
craig bot pushed a commit that referenced this issue Aug 21, 2019
@rohany
Merge #39786
9e76362 
39786: cli: Extending locality assignment for cockroach demo nodes r=rohany a=rohany

This PR allows for setting multiple tiers of locality
for cockroach demo nodes, as opposed to previous work
allowing for only a single tier to be set for each node.

Now, use a colon to separate the locality information
for each demo node. For example,

```
--demo-locality=region=us-east1,az=1:region=us-east1,az=2:region=us-east1,az=3
```

Fixes #39780.

Release note (cli change): Extends the cockroach demo node locality setting to allow for multiple locality tiers per demo node.

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig craig bot closed this as completed in 9c2b1e4 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
A-demo A-partitioning C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: Extending locality assignment for cockroach demo nodes rohany/cockroach
2 participants
@rohany @awoods187