Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: match transactions tooltip language to docs #40376

Closed
awoods187 opened this issue Aug 30, 2019 · 0 comments · Fixed by #40646
Closed

sql: match transactions tooltip language to docs #40376

awoods187 opened this issue Aug 30, 2019 · 0 comments · Fixed by #40646
Assignees
@rafiss
Labels
A-sql-execution Relating to SQL execution. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@awoods187
Copy link
Contributor

In the new transactions dashboard, the tooltip is slightly confusing as currently worded:

image

The total number of transactions opened, committed, rolled back, or aborted per second across all nodes.

In the docs, we use initiated.

We should update the tooltip to say:

The total number of transactions initiated, committed, rolled back, or aborted per second across all nodes
@awoods187 awoods187 added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Aug 30, 2019
@awoods187 awoods187 added A-sql-execution Relating to SQL execution. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. labels Aug 30, 2019
@rafiss rafiss self-assigned this Sep 10, 2019
@rafiss rafiss mentioned this issue Sep 10, 2019
Merged
craig bot pushed a commit that referenced this issue Sep 10, 2019
@rafiss
Merge #40646
5bfc009 
40646: ui: update wording of tooltip for transactions chart r=rafiss a=rafiss

Use the word "initiated" instead of "opened" to match the docs better.

closes #40376

Release note: None

Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig craig bot closed this as completed in 5e9c959 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-sql-execution Relating to SQL execution. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update wording of tooltip for transactions chart rafiss/cockroach
2 participants
@rafiss @awoods187