Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: improve output of show ranges #40467

Closed
awoods187 opened this issue Sep 4, 2019 · 2 comments · Fixed by #40501
Closed

sql: improve output of show ranges #40467

awoods187 opened this issue Sep 4, 2019 · 2 comments · Fixed by #40501
Assignees
@solongordon @rohany
Labels
A-partitioning C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@awoods187
Copy link
Contributor

We've made a number of improvements to SHOW RANGES in 19.2 including adding locality. As a result, this is the current output:

image

This output can be confusing because:

  • The leaseholder column breaks up the replicas and localities columns
  • Locality order follows the order of the replica column but it doesn't put the leseholder first which is the previous column. This ordering will invariably trip up users
  • Leaseholder location is one of the most important performance indicators and it's not immediately obvious where that replica lives

I think we should put the leaseholder column first, follow it with a leaseholder locality column, add then follow with the remaining replicas and their locations.

Alternatively, it would be great if there was one way to represent this via one column. Or a way to convey leaseholder replicas in the replica list.
@awoods187 awoods187 added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Sep 4, 2019
@awoods187 awoods187 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-partitioning and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Sep 4, 2019
@rohany
Copy link
Contributor

rohany commented Sep 4, 2019

I think theres too much information to show for one column -- I think the leaseholder id, leaseholder locality, replicas list, replica localities makes the most sense

rohany added a commit to rohany/cockroach that referenced this issue Sep 5, 2019
@rohany
sql: Reorder show ranges output to be clearer
24b629d 
The output of show ranges had column orderings that at a quick glance
could lead to users making the wrong conclusions about their
partitioning setup. This PR adjusts the columns and adds more readily
accessible information about the lease_holder node's locality.

Fixes cockroachdb#40467.

Release note (sql change): Reorder columns in show ranges output
@rohany rohany mentioned this issue Sep 5, 2019
Merged
craig bot pushed a commit that referenced this issue Sep 5, 2019
@rohany @nvanbenschoten
Merge #40501 #40519
55c33fd 
40501: sql: Reorder show ranges output to be clearer r=rohany a=rohany

The output of show ranges had column orderings that at a quick glance
could lead to users making the wrong conclusions about their
partitioning setup. This PR adjusts the columns and adds more readily
accessible information about the lease_holder node's locality.

Fixes #40467.

Release note (sql change): Reorder columns in show ranges output

40519: workload: ignore syntax error on INJECT STATISTICS against v2.0 r=nvanbenschoten a=nvanbenschoten

Fixes #40463.

Release note: None

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig craig bot closed this as completed in 5f8a9d7 Sep 5, 2019
@awoods187
Copy link
Contributor Author

This looks good:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solongordon solongordon

@rohany rohany

Labels
A-partitioning C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: Reorder show ranges output to be clearer rohany/cockroach
3 participants
@solongordon @rohany @awoods187